feat(routing): support promise in message repo #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #959 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 475 475
Lines 11417 11417
Branches 1804 1804
=======================================
Hits 10020 10020
Misses 1393 1393
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. |
berendsliedrecht
approved these changes
Jul 24, 2022
| takeFromQueue(connectionId: string, limit?: number): EncryptedMessage[] | ||
| add(connectionId: string, payload: EncryptedMessage): void | ||
| takeFromQueue(connectionId: string, limit?: number): EncryptedMessage[] | Promise<EncryptedMessage[]> | ||
| add(connectionId: string, payload: EncryptedMessage): void | Promise<void> |
There was a problem hiding this comment.
Can this still be sync? I thought all repository operations are async.
There was a problem hiding this comment.
The message repository is a special type of repository. We should probably rework this in the near future if we want to start using AFJ as a mediator. For now this makes it possible to make a custom repo implementation based on the indy wallet storage (which is indeed async).
There was a problem hiding this comment.
It should probably be called something like queue (as that's what is is based on the methods e.g. takeFromQueue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Timo Glastra [email protected]